-
Notifications
You must be signed in to change notification settings - Fork 558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MDAL] Add tools, drivers #5383
Conversation
It seems enabling the tools (mdalinfo executable) triggers linking errors on Linux (only):
|
Things are a bit in flux here trying to get memory sanitizer working in CI for Julia: JuliaLang/julia#46349 |
I'm not into sanitizers, is there a way to disable it for building the executables? |
If there was a way to avoid mismatches we'd have put an automated fix in place already. The fact that there is no solution at the moment was the whole point of previous message. We're figuring out what to do as we go. |
Just to close the circle, the version of BBB on Yggdrasil master was update to avoid the msan issue, so if this is rebased, it might be able to move forward. |
This has been rerun already after #5391, and |
The remaining error
looks very much like JuliaPackaging/BinaryBuilderBase.jl#163, which is weird because it should have been fixed already. |
This adds building some Executables, those errors happen on linking those. If I want to build this with NetCDF on Windows, should I also build NetCDF with |
Odd, on x64-linux-musl, |
And when cheating, and just checking whether a hdf5 library is available, we now also fail on all Windows platforms:
Note sure if that's a bug, or there are explicit version checks or so. |
The problem is that something is pushing
Needless to say that's not a great idea. You can delete
Quoting from the documentation:
|
As it might make JuliaPackaging#5383 build on Windows
* [HDF5] Also include dll.a in the output on Windows As it might make #5383 build on Windows * Update build_tarballs.jl * Update build_tarballs.jl
🎉 I'm still missing NetCDF on Windows though, which does work if we don't use |
This now adds NetCDF, HDF5 to x64 Windows and Linux, and to macOS, which roughly enables all drivers for the most popular platforms. I'm happy to merge this. |
Windows builds have less drivers (due to NetCDF missing) than other platforms: https://github.com/evetion/MDAL.jl/actions/runs/2934632776